Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #12403 FP mallocOnClassWarning for RAII class #5930

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Fix #12403 FP mallocOnClassWarning for RAII class #5930

merged 1 commit into from
Jan 31, 2024

Conversation

chrchr-github
Copy link
Collaborator

No description provided.

danmar
danmar approved these changes Jan 31, 2024
View reviewed changes
Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

it's not an ideal solution of course.. ideally we would check what the typeScope would do with the variable.

@chrchr-github
Copy link
Collaborator Author

Well, given that open() doesn't even allocate memory, the warning was just totally off...

@chrchr-github chrchr-github merged commit 5c59d86 into danmar:main Jan 31, 2024
64 checks passed
@chrchr-github chrchr-github deleted the chr_Fix12403 branch January 31, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmar danmar danmar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrchr-github @danmar